Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Hit counter #84

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add a Hit counter #84

wants to merge 2 commits into from

Conversation

AlexKnauth
Copy link
Contributor

@AlexKnauth AlexKnauth commented Sep 18, 2024

A draft PR, only to be considered after LiveSplit/LiveSplit#2528 has gone through into a main release.

Adds a Hit counter that sets these LiveSplit Custom Variables:

  • hits cumulative hits so far in the current run
  • pb hits the minimum number of total hits in previous finished runs
  • delta hits difference between current run hits and "best-pace" hits
  • segment hits hits in this segment of the current run

Also adds a setting for the Hit counter which can either be:

  • None no hit counter
  • Hits / dream falls includes falling in dream plats as a hit, as well as the normal things
  • Hits / damage does not count falling in dream plats as a hit

For local testing, I also have a branch with the DLL built here: https://github.com/AlexKnauth/LiveSplit.HollowKnight/tree/hits-dll

Tasks:

  • Fix behavior on skip split, so that segment hits get transferred to the new current split.
  • Fix behavior on undo split, so that it also undoes any change to the ComparisonHits that might have come from the split that needed to be undone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant